-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Semantic Search #1688
base: main
Are you sure you want to change the base?
Conversation
f186f44
to
817c094
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think openSearchApi.js and openSearchAPI.js are duplicates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an experiment, would you please try writing the collection of API calls as an Architect deploy.end
plugin in this project, rather than using the openSearchApi.js file? I'd like to see what that looks like.
b0f0e7f
to
9875637
Compare
31addd7
to
a370381
Compare
dcaba60
to
58a4f69
Compare
was there anything else we wanted to implement for this PR? |
I don't believe so. I want to implement the changes for improving semantic search in another PR. |
Please resolve merge conflicts. |
Alright. Will do. |
Add postdeploy-search module for making API calls to Search cluster.
…to its GitHub repository. Also update package-lock.json to point to new version of 'architect-plugin-search'.
Also remove previously added comments.
Co-authored-by: Tyler Barna <[email protected]>
708551f
to
a564ad0
Compare
Sync package.json and package-lock.json. Fix prettier issues.
19c64a3
to
168293d
Compare
Done. |
Implement Semantic Search in circulars.server.ts. Add openSearchApi.js module for making API calls to OpenSearch cluster